fix: switch to single bind for resolve connect error with multi-addresses machine #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #172 +/- ##
==========================================
- Coverage 83.59% 83.20% -0.39%
==========================================
Files 68 68
Lines 9019 9032 +13
==========================================
- Hits 7539 7515 -24
- Misses 1480 1517 +37 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| session | ||
| ); | ||
| self.switch_to_incoming(session); | ||
| State::IncomingWait { at_ms } => { |
Check warning
Code scanning / clippy
unused variable: at_ms Warning
| } | ||
| } | ||
| } | ||
| State::OutgoingWait { requester, .. } => { |
Check warning
Code scanning / clippy
unused variable: requester Warning
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add config bind-addr by specific SocketAddr instead of port only. This is for resolving connect error with some machine with multiple ip addresses.
In future we should support multiple bind addresses, this is tracked with separated issue: #171