Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: task clean-up with new sans-io-runtime #179

Conversation

giangndm
Copy link
Contributor

@giangndm giangndm commented Nov 8, 2024

No description provided.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 38.02521% with 295 lines in your changes missing coverage. Please review.

Project coverage is 81.10%. Comparing base (5d16fd6) to head (1262182).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
packages/network/src/controller_plane/features.rs 28.94% 27 Missing ⚠️
packages/network/src/data_plane/features.rs 27.02% 27 Missing ⚠️
packages/network/src/worker.rs 12.50% 21 Missing ⚠️
packages/network/src/controller_plane.rs 33.33% 20 Missing ⚠️
packages/network/src/data_plane.rs 28.57% 20 Missing ⚠️
packages/network/src/controller_plane/services.rs 57.14% 18 Missing ⚠️
packages/network/src/data_plane/services.rs 57.50% 17 Missing ⚠️
packages/network/src/features/router_sync.rs 33.33% 14 Missing ⚠️
packages/network/src/features/alias.rs 31.57% 13 Missing ⚠️
packages/network/src/features/data.rs 35.00% 13 Missing ⚠️
... and 12 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
- Coverage   83.21%   81.10%   -2.12%     
==========================================
  Files          68       68              
  Lines        9051     9445     +394     
==========================================
+ Hits         7532     7660     +128     
- Misses       1519     1785     +266     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giangndm giangndm merged commit 794aecc into 8xFF:master Nov 8, 2024
8 of 10 checks passed
@github-actions github-actions bot mentioned this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant