feat: surface some globals around restarts for the manage command #58
+124
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark deVilliers <markdevilliers@gmail.com>
mdevilliers
changed the title
internal/ctl/connectors/manage.go
Outdated
| manageCmd.Flags().DurationVar(¶ms.GlobalConnectorRestartPeriod, "global-connector-restart-period", params.GlobalConnectorRestartPeriod, "period of time between failed connector restarts") | ||
| _ = viper.BindPFlag("global-connector-restart-period", manageCmd.PersistentFlags().Lookup("global-connector-restart-period")) | ||
|
|
||
| manageCmd.Flags().IntVar(¶ms.GlobalMaxTaskRestarts, "global-task-max-restarts", params.GlobalMaxTaskRestarts, "maximum times a failed task will be restarted") |
There was a problem hiding this comment.
max-task or task-max?
internal/ctl/connectors/manage.go
Outdated
| @@ -82,6 +90,18 @@ if you specify --once then it will sync once and then exit.`, | |||
| manageCmd.Flags().DurationVar(¶ms.HTTPClientTimeout, "http-client-timeout", params.HTTPClientTimeout, "HTTP client timeout") | |||
| _ = viper.BindPFlag("http-client-timeout", manageCmd.PersistentFlags().Lookup("http-client-timeout")) | |||
|
|
|||
| manageCmd.Flags().IntVar(¶ms.GlobalMaxConnectorRestarts, "global-connector-max-restarts", params.GlobalMaxConnectorRestarts, "maximum times a failed connector will be restarted") | |||
There was a problem hiding this comment.
maybe these strings could be const as they appear in a couple of places?
There was a problem hiding this comment.
I don't think that would be an improvement.
There was a problem hiding this comment.
Im talking about these strings global-connector-max-restarts etc... I think it is an improvement to move these into consts.
the4thamigo-uk
previously approved these changes
Mar 9, 2020
Signed-off-by: Mark deVilliers <markdevilliers@gmail.com>
mdevilliers
force-pushed
the
implelment_restart_task_policy
branch
from
7f9544c
to
290ed03
Compare
the4thamigo-uk
approved these changes
Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.