Skip to content

Commit

Permalink
Add Cargo.lock (again)
Browse files Browse the repository at this point in the history
`Cargo.lock` files were added in huggingface#229 and then removed about a month
later in huggingface#253 (with the justification that "cargo.lock messes up
benchmarks").

Shortly after, the Rust project guidance was updated to encourage
committing lockfiles:

https://blog.rust-lang.org/2023/08/29/committing-lockfiles.html
https://doc.rust-lang.org/cargo/faq.html#why-have-cargolock-in-version-control
rust-lang/cargo#8728

Let's add the lockfiles back to make builds reproducible and
deterministic, especially for consumers of Python bindings.
  • Loading branch information
9999years committed Apr 18, 2024
1 parent ebf453b commit 649fdd8
Show file tree
Hide file tree
Showing 4 changed files with 1,327 additions and 2 deletions.
2 changes: 0 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
safetensors/target
safetensors/**/Cargo.lock
bindings/python/Cargo.lock
*.bin
*.h5
*.msgpack
Expand Down
351 changes: 351 additions & 0 deletions bindings/python/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 649fdd8

Please sign in to comment.