Merge pull request #1399 from 99designs/prevent-possible-error-deadlock

Dont hold error lock when calling into error presenters

graphql/context_response.go

@@ -45,10 +45,11 @@ func AddErrorf(ctx context.Context, format string, args ...interface{}) {
 func AddError(ctx context.Context, err error) {
 	c := getResponseContext(ctx)
 
+	presentedError := c.errorPresenter(ctx, ErrorOnPath(ctx, err))
+
 	c.errorsMu.Lock()
 	defer c.errorsMu.Unlock()
-
-	c.errors = append(c.errors, c.errorPresenter(ctx, ErrorOnPath(ctx, err)))
+	c.errors = append(c.errors, presentedError)
 }
 
 func Recover(ctx context.Context, err interface{}) (userMessage error) {

graphql/context_response_test.go

@@ -79,3 +79,16 @@ func TestAddError(t *testing.T) {
 		})
 	}
 }
+
+func TestGetErrorFromPresenter(t *testing.T) {
+	ctx := WithResponseContext(context.Background(), func(ctx context.Context, err error) *gqlerror.Error {
+		errs := GetErrors(ctx)
+
+		// because we are still presenting the error it is not expected to be returned, but this should not deadlock.
+		require.Len(t, errs, 0)
+		return DefaultErrorPresenter(ctx, err)
+	}, nil)
+
+	ctx = WithFieldContext(ctx, &FieldContext{})
+	AddError(ctx, errors.New("foo1"))
+}