Following the getting started fails with go1.18beta2 #1961

nlepage · 2022-02-10T20:25:03Z

What happened?

Trying to follow the getting started fails at step go run github.com/99designs/gqlgen init.

Adding the --verbose flag produces the following error message:

internal error: package "github.com/vektah/gqlparser/v2/ast" without types was imported from "github.com/99designs/gqlgen/graphql/introspection"

Further executions of the generate command produce the same error.

What did you expect?

Being able to go through the getting started without errors.

Minimal graphql.schema and models to reproduce

N/A

versions

gqlgen v0.16.0
go v1.18beta2
go modules

Complete logs (reproduced in a docker container)

$ docker container run -it --rm golang:1.18-rc bash
root@bf9534c22485:/go# mkdir example
root@bf9534c22485:/go# cd example
root@bf9534c22485:/go# go mod init example
go: creating new go.mod: module example
root@bf9534c22485:/go/example# printf '// +build tools\npackage tools\nimport _ "github.com/99designs/gqlgen"' | gofmt > tools.go
root@bf9534c22485:/go# go mod tidy
go: finding module for package github.com/99designs/gqlgen
go: downloading github.com/99designs/gqlgen v0.16.0
go: found github.com/99designs/gqlgen in github.com/99designs/gqlgen v0.16.0
go: downloading github.com/matryer/moq v0.2.3
go: downloading github.com/urfave/cli/v2 v2.3.0
go: downloading github.com/vektah/gqlparser/v2 v2.2.0
go: downloading github.com/stretchr/testify v1.4.0
go: downloading github.com/gorilla/websocket v1.4.2
go: downloading golang.org/x/tools v0.1.5
go: downloading gopkg.in/yaml.v2 v2.2.4
go: downloading github.com/hashicorp/golang-lru v0.5.0
go: downloading github.com/mitchellh/mapstructure v1.2.3
go: downloading github.com/andreyvit/diff v0.0.0-20170406064948-c7f18ee00883
go: downloading github.com/agnivade/levenshtein v1.1.0
go: downloading gopkg.in/check.v1 v1.0.0-20190902080502-41f04d3bba15
go: downloading github.com/davecgh/go-spew v1.1.1
go: downloading github.com/pmezard/go-difflib v1.0.0
go: downloading github.com/sergi/go-diff v1.1.0
go: downloading github.com/kr/pretty v0.1.0
go: downloading github.com/kr/text v0.1.0
go: downloading github.com/cpuguy83/go-md2man/v2 v2.0.1
go: downloading github.com/dgryski/trifles v0.0.0-20200323201526-dd97f9abfb48
go: downloading github.com/arbovm/levenshtein v0.0.0-20160628152529-48b4e1c0c4d0
go: downloading github.com/russross/blackfriday/v2 v2.1.0
go: downloading golang.org/x/mod v0.4.2
go: downloading golang.org/x/sys v0.0.0-20210510120138-977fb7262007
go: downloading golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1
root@bf9534c22485:/go/example# go run github.com/99designs/gqlgen --verbose init
Creating gqlgen.yml
Creating graph/schema.graphqls
Creating server.go
Generating...
internal error: package "github.com/vektah/gqlparser/v2/ast" without types was imported from "github.com/99designs/gqlgen/graphql/introspection"
exit status 1
root@bf9534c22485:/go/example# go run github.com/99designs/gqlgen --verbose generate
internal error: package "github.com/vektah/gqlparser/v2/ast" without types was imported from "github.com/99designs/gqlgen/graphql/introspection"
exit status 1

The text was updated successfully, but these errors were encountered:

frederikhors · 2022-02-10T20:26:46Z

Please can you add a github repo for reproduction? Thanks.

nlepage · 2022-02-10T20:36:33Z

Please can you add a github repo for reproduction. Thanks.

Sure.

Additional information: I managed to make it work on a fork by adding NeedDeps in the flags given to golang.org/x/tools/go/packages.Load(), however I have pretty much no idea what I am doing, and I did this to fix a different error...

nlepage · 2022-02-10T20:45:54Z

Here you go: https://github.com/nlepage/gqlgen-issue-1961

nlepage · 2022-02-10T20:55:16Z

The error I fixed by adding the NeedDeps flag was: Unexpected package creation during export data loading.

There is a go issue about this error: golang/go#45584, not sure if this is related.

frederikhors · 2022-02-10T21:37:34Z

I think we should wait for 1.18 stable to better understand. Please can you monitor this for us? You can close if it works when 1.18 stable is released. Thanks.

nlepage · 2022-02-11T08:03:59Z

Please can you monitor this for us?

No problem.

adaya-sprobe · 2022-03-11T06:33:06Z

I just tried this using 1.18rc1. It works.

nlepage · 2022-03-11T07:31:07Z

@adaya-sprobe This issue was reported for gqlgen v0.16.0, it seems to have been fixed in further versions...

gqlgen v0.16.0 is still broken with go1.18rc1, and will probably be with the final release.

It may have been fixed in gqlgen v0.17.0 by this commit : 9866507#diff-ca34562b44ad709eeae25522801f5282e8a197c52f345d38b13180c1cae88e83

nlepage · 2022-03-11T08:14:43Z

The problem reported by this issue is fixed in gqlgen v0.17, so I'm closing this.

However I'm still having an issue with generate returning the error: Unexpected package creation during export data loading on a project I'm writing using go1.18, I will open another issue.

Desuuuu · 2022-03-11T08:17:39Z

The original issue with v0.16 can be solved by upgrading golang.org/x/tools to v0.1.8+.

As for the other issue, you can reproduce it using this: https://github.com/Desuuuu/gqlgen-issue

Adding the NeedDeps flag as mentionned in #1961 (comment) does seem to fix the problem.

ivanvanderbyl · 2022-03-14T12:30:21Z

I'm still experiencing the Unexpected package creation during export data loading issue with v0.17.1 (Go 1.18-rc1), and updating golang.org/x/tools as mentioned above didn't help. However, the patch mentioned by @nlepage earlier does seem to fix the problem.

nlepage · 2022-03-14T13:40:37Z

@ivanvanderbyl @Desuuuu I think this is worth opening another issue.

frederikhors · 2022-03-14T13:49:56Z

Please create a reproduction repo before opening a new issue.

nlepage · 2022-03-14T14:04:31Z

Please create a reproduction repo before opening a new issue.

@frederikhors I think that's what @Desuuuu did, as mentionned in #1961 (comment) : https://github.com/Desuuuu/gqlgen-issue

Desuuuu · 2022-03-14T18:39:21Z

The Unexpected package creation during export data loading bug appears to be an issue with golang.org/x/tools as well.

It has been reported here.

frederikhors · 2022-03-14T18:48:59Z

I think we should wait for 1.18 official to re-open this.

mojtabacazi · 2022-03-16T00:36:06Z

I think we should wait for 1.18 official to re-open this.

@frederikhors go1.18 is out and as far as I can tell this is still an issue with gqlgen 17.1

it can be fixed by adding NeedDeps

frederikhors · 2022-03-16T09:49:38Z

@StevenACoffman I think we have a problem with Go 1.18. I'm reopening this. :(

Signed-off-by: Steve Coffman <steve@khanacademy.org>

StevenACoffman · 2022-03-16T11:44:20Z

Thanks very much @nlepage, @mojtabacazi, @Desuuuu , and @ivanvanderbyl and @frederikhors !

StevenACoffman · 2022-03-21T14:15:38Z

BTW, I cut a new gqlgen v0.17.2 release now that Go 1.18 is out and I didn't see any reports of issues with the fix.

Go 1.18 is out! So we should run tests on it. gqlgen had some issues with it (see 99designs/gqlgen#1961 and golang/go#45584) so I updated that too, which updated some other things. Test plan: make check

Go 1.18 is out! So we should run tests on it. Additionally, gqlgen had some issues with it (see 99designs/gqlgen#1961 and golang/go#45584) so I updated that too, which updated some other things. Finally, latest gqlgen requires 1.16+, and it's time for us to do the same anyway, so we can use `embed` and other newer goodies. So I dropped running tests for 1.14 and 1.15, and bumped the module language version. Test plan: make check

LeugimAtreides · 2022-04-01T20:34:29Z

Hello I'm running the tutorial and running gqlgen v0.17.2 and go1.18 windows/amd64 it appears that the command 'go run github.com/99designs/gqlgen init' causes this same issue again

nlepage closed this as completed Mar 11, 2022

frederikhors reopened this Mar 16, 2022

StevenACoffman added a commit that referenced this issue Mar 16, 2022

Fix #1961 for Go 1.18

bbc902c

Signed-off-by: Steve Coffman <steve@khanacademy.org>

StevenACoffman closed this as completed in 87fc5f2 Mar 16, 2022

emmanuel099 mentioned this issue Mar 17, 2022

mockery v2.10.0 cannot generate file on go1.18 vektra/mockery#434

Closed

benjaminjkraft mentioned this issue Mar 22, 2022

Update tested Go versions (and deps) Khan/genqlient#179

Merged

6 tasks

renovate bot mentioned this issue Apr 2, 2022

Update module github.com/99designs/gqlgen to v0.17.2 kosnu/habook#207

Merged

1 task

renovate bot mentioned this issue May 27, 2022

fix(deps): update module github.com/99designs/gqlgen to v0.17.9 seed-hypermedia/mintter#208

Merged

1 task

andaaron mentioned this issue Jul 15, 2022

error while running go generate #2211

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Following the getting started fails with go1.18beta2 #1961

Following the getting started fails with go1.18beta2 #1961

nlepage commented Feb 10, 2022

frederikhors commented Feb 10, 2022 •

edited

Loading

nlepage commented Feb 10, 2022

nlepage commented Feb 10, 2022

nlepage commented Feb 10, 2022

frederikhors commented Feb 10, 2022

nlepage commented Feb 11, 2022

adaya-sprobe commented Mar 11, 2022

nlepage commented Mar 11, 2022 •

edited

Loading

nlepage commented Mar 11, 2022

Desuuuu commented Mar 11, 2022 •

edited

Loading

ivanvanderbyl commented Mar 14, 2022 •

edited

Loading

nlepage commented Mar 14, 2022

frederikhors commented Mar 14, 2022

nlepage commented Mar 14, 2022 •

edited

Loading

Desuuuu commented Mar 14, 2022

frederikhors commented Mar 14, 2022

mojtabacazi commented Mar 16, 2022 •

edited

Loading

frederikhors commented Mar 16, 2022

StevenACoffman commented Mar 16, 2022

StevenACoffman commented Mar 21, 2022

LeugimAtreides commented Apr 1, 2022

Following the getting started fails with go1.18beta2 #1961

Following the getting started fails with go1.18beta2 #1961

Comments

nlepage commented Feb 10, 2022

What happened?

What did you expect?

Minimal graphql.schema and models to reproduce

versions

Complete logs (reproduced in a docker container)

frederikhors commented Feb 10, 2022 • edited Loading

nlepage commented Feb 10, 2022

nlepage commented Feb 10, 2022

nlepage commented Feb 10, 2022

frederikhors commented Feb 10, 2022

nlepage commented Feb 11, 2022

adaya-sprobe commented Mar 11, 2022

nlepage commented Mar 11, 2022 • edited Loading

nlepage commented Mar 11, 2022

Desuuuu commented Mar 11, 2022 • edited Loading

ivanvanderbyl commented Mar 14, 2022 • edited Loading

nlepage commented Mar 14, 2022

frederikhors commented Mar 14, 2022

nlepage commented Mar 14, 2022 • edited Loading

Desuuuu commented Mar 14, 2022

frederikhors commented Mar 14, 2022

mojtabacazi commented Mar 16, 2022 • edited Loading

frederikhors commented Mar 16, 2022

StevenACoffman commented Mar 16, 2022

StevenACoffman commented Mar 21, 2022

LeugimAtreides commented Apr 1, 2022

frederikhors commented Feb 10, 2022 •

edited

Loading

nlepage commented Mar 11, 2022 •

edited

Loading

Desuuuu commented Mar 11, 2022 •

edited

Loading

ivanvanderbyl commented Mar 14, 2022 •

edited

Loading

nlepage commented Mar 14, 2022 •

edited

Loading

mojtabacazi commented Mar 16, 2022 •

edited

Loading