Transport for application/x-www-form-urlencoded content type #2611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are multiple ways form data can be encoded. 'multipart' is just one of them - there are also 'application/x-www-form-urlencoded' (which will be added in next commit) and 'text/plain' encodings. Let each encoding have it's own form_xxxx file and tests.
This commit adds transport that handles form POST with content
type set to 'application/x-www-form-urlencoded'.
Form body can be json, urlencoded parameters or plain text.
Example:
```
curl -X POST 'http://server/query' -d '{name}' -H "Content-Type: application/x-www-form-urlencoded"
```
Enable it in your GQL server with:
```
srv.AddTransport(transport.UrlEncodedForm{})
```
No other changes but this rewrite to switch.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one more (and the last) transport that we're missing in stock gqlgen (I'm done with transports after this PR).
It works with
application/x-www-form-urlencodedtransports that a big part of out clients use. It is similar to both multipart and graphql transports, but I still decided to do a separate file. Anyone interested in it can enable it in server config, so it's backwards compatible, it wont break anything.Tests and doc changes are also part of this PR.
transport_form.gois renamed totransport_form_multipart.goas we now have two form transports (transport_form_multipart.goandtransport_form_urlencoded.go).Comments are welcome.
I have: