refactor: significantly clean up the federation.gotpl template #3187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some configurations weren't working due to a missing resolver.
clayne11
force-pushed
the
curtis.layne/fed-refactor
branch
3 times, most recently
from
2ca899a
to
6b2c54a
Compare
clayne11
force-pushed
the
curtis.layne/fed-refactor
branch
3 times, most recently
from
c4b74f9
to
f8f648b
Compare
This enables engineers to more easily run the debugger on the Federation example. Updated README to show how to use it.
There were a number of inline structs and inline functions that made it extremely hard to reason about what the code is doing. Split these out into smaller functions with less closures and mutation. Part of the setup to help with fixing 99designs#2991.
clayne11
force-pushed
the
curtis.layne/fed-refactor
branch
from
f8f648b
to
7eebd7f
Compare
| @@ -5,6 +5,7 @@ | |||
| "main": "gateway/index.js", | |||
| "type": "module", | |||
| "scripts": { | |||
| "start-gateway": "node gateway/index.js", | |||
There was a problem hiding this comment.
Thanks! Saves me time.
| @@ -1,3 +1,14 @@ | |||
| ### Federation | |||
|
|
|||
| [Read the docs](https://gqlgen.com/recipes/federation/) | |||
|
|
|||
| ## Testing | |||
There was a problem hiding this comment.
I am a huge fan of making it easier for people besides me to debug through this 😆
StevenACoffman
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
This looks good to me, but I would love to move things from federation.gotpl to federation.go wherever possible. Some of the static analysis tooling is defeated when logic is hidden in the federation.gotpl, and it's harder to read and maintain inside a template.
The only thing about this PR that gives me pause is that it doesn't improve things in that regard, but it maybe that is in your future plans.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a number of inline structs and inline functions that made it extremely hard to reason about what the code is doing. Split these out into smaller functions with less closures and mutation.
Part of the setup to help with fixing #2991.
There should be no behavior changes in this PR, simply refactoring code.
I also added a new package
_examples/allto make it easier to debug Federation subgraphs.Tested by running this query in the
_example/federationdemo before and after my changes: