New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If the graphql.AddError err arg is nil, early return #3445

Merged

StevenACoffman merged 1 commit into master from add_error_nil_no_op

Dec 20, 2024

Collaborator

StevenACoffman commented Dec 20, 2024 •

edited

Loading

Fixes #3410 so that graphql.AddError is a no-op if the error is nil.

Signed-off-by: Steve Coffman steve@khanacademy.org


          If the graphql.AddError err arg is nil, early return

888df00

Signed-off-by: Steve Coffman <steve@khanacademy.org>

coveralls commented Dec 20, 2024

coverage: 73.887% (-0.02%) from 73.91%
when pulling 888df00 on add_error_nil_no_op
into b95ea13 on master.

StevenACoffman merged commit 3d0c92a into master

18 checks passed

StevenACoffman deleted the add_error_nil_no_op branch

December 20, 2024 19:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet