Fix Issue With Argument Pointer Type #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vektah you think this is worth getting on |
Maybe lets ship to master and try and get a v0.6.0 (excluding next) out today so we don't have a bunch of untagged stuff out for too long? |
added 5 commits
October 2, 2018 12:00
This fails if a client still sends a null value. If an arg is nullable but has a default, then null is still a valid value to send through.
mathewbyrne
force-pushed
the
fix-null-arg-error
branch
from
87ec587
to
48724de
Compare
cgxxv
pushed a commit
to cgxxv/gqlgen
that referenced
this pull request
Mar 25, 2022
Fix Issue With Argument Pointer Type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #346 there was an issue revealed where a non-nullable argument with a default value was not passing an input
nullthrough to the resolver, and instead was giving an error.The reason for this is that if an argument has a default and is a pointer (nullable), the pointer is stripped. This cha This change removes this behaviour and keeps type a pointer. If an argument is nullable, then null is always a valid value.
Fixes #346