Commits on Mar 27, 2018

1. plumb/basic: Move forward first so we don't wrap around …

   Fixes 9fans#122, 9fans#140.
   
   As reported in 9fans#122, `file:1:1` moves to the end of the file,
   and `file:1:2` fails with “address out of range”.
   
   I’ll use file:2:3 as an example so we can tell the line and column number apart.
   
   What’s happening is this:
   plumb/basic matches `2:3` using twocolonaddr (from plumb/fileaddr),
   then sets addr to `2-9fans#1+9fans#3`
   (the 1 is constant and was introduced because column numbers are 1-based).
   Acme interprets this in three steps:
   
   1. find the range (q0, q1) that contains line 2
   2. create the range (q2, q2) where q2 = q0 - 1
   3. create the range (q3, q3) where q3 = q2 + 3
   
   The second step has a branch where if q0 == 0 and 1 > 0
   (remember that 1 is constant and comes form plumb/basic),
   q0 is set to the end of the file.
   This makes addressing things at the end of the file easier.
   
   The problem then is that if we select line 1,
   which starts at the beginning of the file,
   q0 is always 0 and the branch in step 2) will always be used.
   `1:1` is interpreted as `1-9fans#1+9fans#1` which starts at 0, wraps around to the end of the file, then moves 1 character backwards and then forwards again, ending at the end of the file.
   `1:2` is interpretes as `1-9fans#1+9fans#2` which starts at 0, wraps around to the end od the file, then moves 1 character backwards and tries moving 2 characters forwards beyond the end of the file, resulting in the out of range error.
   
   In 9fans#140 @rsc proposed transforming `:X:Y` into `:X-#0+#Y-9fans#1` instead since that
   avoids wrapping around by not moving backwards at first.
   This change modifies `plumb/basic` to do that.

   

   mkhl committed Mar 27, 2018
   Configuration menu

   • View commit details
   • Copy full SHA for 219d504
   • Browse repository at this point

   Copy the full SHA

   219d504 View commit details

   Browse the repository at this point in the history