Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upas/nfs: fix null date when message is sent to plumber #263

Merged
merged 1 commit into from
Sep 19, 2019

Conversation

telephil
Copy link
Contributor

When fetching, messages are sent to plumber as soon as the ENVELOPE part is read.
The date field of the message is sent when the INTERNALDATE part is read and
there is no guarantee that this will be read before the ENVELOPE.
This bug can be observed when using faces(1) which will retrieve messages with
a null date and then always display a 'Jan 1' date instead of the correct one.
The fix is to simply send the message to plumber after having read all parts,
thus ensuring the message is complete.

Fix issue #262

    When fetching, messages are sent to plumber as soon as the ENVELOPE part is read.
    The date field of the message is sent when the INTERNALDATE part is read and
    there is no guarantee that this will be read before the ENVELOPE.
    This bug can be observed when using faces(1) which will retrieve messages with
    a null date and then always display a 'Jan 1' date instead of the correct one.
    The fix is to simply send the message to plumber after having read all parts,
    thus ensuring the message is complete.
@dancrossnyc dancrossnyc merged commit 9389de6 into 9fans:master Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants