all: sync and dedup the creation of the SYSNAME and OBJTYPE env vars #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't verify 'til Monday when I get to the office. But it's a trivial fix so I wouldn't worry ... |
nsajko
force-pushed
the
SYSNAME_OBJTYPE_merge_and_deduplication
branch
from
98095fc to
582ab1c
Compare
|
Please use shorter file names. When I saw a file named |
rsc
added a commit
that referenced
this pull request
Jan 10, 2020
Also note that the file must be valid shell and mk input. For #321.
|
I pushed a CL moving the file to src/mkenv. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should prevent the issues of dist/buildmk and src/mkhdr getting out
of synchronization yet again.
I also add a rule for arm64 to the OBJTYPE sed command.
Fixes #243
Fixes #320
Change-Id: I60f69a1f32b5ed5ae5ac8a1659c38e29debed005