feat: implement interface version 3 #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SukkaW
commented
Dec 3, 2024
Comment on lines
3
to
8
| function createCycleSourceError(p: string) { | ||
| return { | ||
| message: `Dependency cycle via ${p}`, | ||
| messageId: 'cycleSource', | ||
| data: { source: p }, | ||
| } | ||
| } |
There was a problem hiding this comment.
eslint-plugin-import-x@4.5.0 has removed all the message and has migrated them all to the messgaeId. So the error has also been updated.
SukkaW
commented
Dec 3, 2024
| if (isBuiltin(source)) | ||
| return { found: true, path: null } | ||
|
|
||
| options ??= {} | ||
| const optionsHash = hashObject(options) | ||
| if (resolver == null) { |
There was a problem hiding this comment.
With interface version 3, the resolver will not be null, so all those hashing and caching below would be skipped~
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR implements the new import resolver interface (un-ts/eslint-plugin-import-x#192).
Now the options hashing only happens with interface version 2.