Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update with v6.3 #94

Merged
merged 4 commits into from
Nov 5, 2019
Merged

Update with v6.3 #94

merged 4 commits into from
Nov 5, 2019

Conversation

augustfly
Copy link
Member

@augustfly augustfly commented Oct 8, 2019

This updates the files to v6.3 on GitHub (original release on July 10, 2019).

@gregschwarz We need to make a list of which issues are closed by this PR. The AASTeX history page doesn't have the updated feature/bugs listed yet for v6.3 so I'm not clear on which are closed. Once we know about them I can add them to the list below so they will auto close when you accept the PR. These are the ones I'm sure about:

closes #56
closes #57
closes #63
closes #68
closes #70
closes #72
closes #74
closes #75
closes #76
closes #77
closes #78
closes #81

I tried looking through the CLS file for documentation of which issues were closed, but I couldn't find enough detail in Amy's comments to make me 100% sure of anything.

@augustfly augustfly added this to the v6.3 milestone Oct 8, 2019
@augustfly augustfly requested a review from gregschwarz October 8, 2019 14:06
@augustfly
Copy link
Member Author

augustfly commented Oct 8, 2019

Here is my "I think" list of issues to be closed. Let me know if I'm right so I can add them above or if I'm wrong before you accept the PR. Of course add more if you know about them.

closes #72 : enforces TOC for accessibility
closes #74 : I hope? This is a nasty little bug.
closes #76 : by accepting the solution already implemented in PR 79
closes #81 : i see a modification of the table note mark style in the new CLS.
closes #83 : I thought we'd discuss this extensively.

@augustfly
Copy link
Member Author

@gregschwarz Can you go through the AASTeX repo issues and list (in this thread) which ones are closed by v6.3? Then I'll update the pull request thread and have you accept the PR. I can go through them after that and finalize any more that are outstanding.

@gregschwarz
Copy link
Contributor

I can confirm that all of the issues mentioned in this thread are addressed in v6.3 with two exceptions. Issue #61 is a conflict between v6.2 and the siunitx.sty package. These can be tricky as common names can be used in different packages, in this case \tablenum, and there is no way to anticipate what will conflict with AASTeX. In the new v6.3 author guide we have some help for authors that run into this specific siunitx.sty problem.

We will continue to document other solutions as they arise. The other exception is issue #83 which unfortunately I forgot to add to the requirements page that was sent to our LaTeX programmer. We should keep this open for the next version.

@augustfly
Copy link
Member Author

Okay, I will manually comment on #61 and #83 after we merge. I think you can go ahead @gregschwarz

@gregschwarz gregschwarz merged commit d59c29e into AASJournals:master Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment