Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling and tests for expression trees #4

Merged
merged 1 commit into from
Sep 3, 2021
Merged

Handling and tests for expression trees #4

merged 1 commit into from
Sep 3, 2021

Conversation

AArnott
Copy link
Owner

@AArnott AArnott commented Aug 28, 2021

These tests repro the cases called out in #3, plus a couple more.

Fixes #3

These tests repro the cases called out in #3, plus a couple more.
@AArnott AArnott marked this pull request as ready for review September 2, 2021 23:06
@codecov-commenter
Copy link

Codecov Report

Merging #4 (9dd2636) into main (09d8a20) will increase coverage by 0.89%.
The diff coverage is 98.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
+ Coverage   94.08%   94.97%   +0.89%     
==========================================
  Files           7        8       +1     
  Lines         169      219      +50     
==========================================
+ Hits          159      208      +49     
- Misses         10       11       +1     
Impacted Files Coverage Δ
src/CSharpIsNullAnalyzer/IOperationExtensions.cs 92.30% <92.30%> (ø)
...CSharpIsNullAnalyzer.CodeFixes/CSIsNull002Fixer.cs 100.00% <100.00%> (ø)
src/CSharpIsNullAnalyzer/CSIsNull001.cs 100.00% <100.00%> (ø)
src/CSharpIsNullAnalyzer/CSIsNull002.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09d8a20...9dd2636. Read the comment docs.

@AArnott AArnott merged commit bf6be54 into main Sep 3, 2021
@AArnott AArnott deleted the fix3 branch November 7, 2021 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

is null and is not null can't be used in expression contexts
3 participants