shift_index functions added into Grid class #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebjameswml
requested changes
Nov 15, 2024
morph/Grid.h
Outdated
| * \param dx The horizontal displacement (in units of number of pixels). | ||
| * \return The column index of the moved pixel | ||
| */ | ||
| I col_after_x_shift (I ind, I dx) |
There was a problem hiding this comment.
I think you're probably right about making these two functions private, so let's do that.
There was a problem hiding this comment.
Not sure how to do this without breaking the unit tests.
Is there some preferred way giving the test file permission to access private functions?
There was a problem hiding this comment.
I'll have a play - I see that I can actually make changes to this PR myself. I'll sort it. And thanks for the other changes, it looks impeccable now :)
…truct on unit tests
If the function is to be unit tested, then it's simplest to keep it part of the public interface of the Grid class. If you want to unit test private parts of a class, you probably need to write a new class specifically for that purpose, which would provide access to the private members (using the friend keyword). But we're not going to do that. There's no great harm in making these two functions public, so I hereby reverse our previous decision.
|
Right, sorted. I'll wait for the CI to finish and merge it after that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've written three functions into Grid.
The functions work with all GridOrders and all GridWraps.
Comprehensive unit tests are included and are passing.
I wondered whether it would be best if only (3) were a public function and have (1) and (2) as private ones? But I'll leave that up to you.