GridVisual selected pixels border enhancements #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We ought to change the size of the pixels if there are borders so that the borders are drawn at exactly the same 'z' as the rest of the grid and the rendering will then be perfect. |
|
Ping @fabien-colonnier I'm just using GridVisual with selected pixels to draw some Opteran stuff. Making a few tweaks |
|
I think we want to draw the borders and grid features at the same z height as the grid. This means that when drawing the grid, its triangles need to be adjusted so that they don't conflict with the borders. This is probably a few days work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug and added option to draw an enclosing rectangle around your selected pixels.