-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meaningless values for {model_name}_cpl_dt in nuopc.runconfig 1deg_jra55do_iaf #55
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ezhilsabareesh8. I assume you tried a negative number, e.g. -999, and it didn't work (that's my recollection)? Did you look into whether we can add comments?
Yes negative numbers cause the I have added comments in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, could we remove all the additional spaces, e.g. atm_cpl_dt = 99999 #not used
. It would nice to have consistent styling across different configs (so that we can do diffs etc) and a single space before the commit is probably simplest
In the TWG meeting today, we agreed to set |
Updated in this commit 5b8acda |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ezhilsabareesh8 et al. LGTM
Please squash and merge to clean up the commit history |
This PR address #132 by setting meaningless values for
{model_name}_cpl_dt
innuopc.runconfig
.