Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Committed git tags show as invalid-email-address #19

Closed
CodeGat opened this issue Feb 25, 2024 · 0 comments · Fixed by #20
Closed

Committed git tags show as invalid-email-address #19

CodeGat opened this issue Feb 25, 2024 · 0 comments · Fixed by #20
Assignees

Comments

@CodeGat
Copy link
Contributor

CodeGat commented Feb 25, 2024

Although the commit shows github-actions as the author, tags show invalid-email-address - see https://github.com/ACCESS-NRI/access-om2-configs/releases/tag/release-1deg_jra55_ryf-1.0

Scouring the internet, we see that the commit email for github-actions should contain the user id for the bot to have the correct icon everywhere: see actions/checkout#1184

Implement the features as noted in that PR.

@CodeGat CodeGat self-assigned this Feb 25, 2024
CodeGat added a commit to ACCESS-NRI/ACCESS-OM2 that referenced this issue Feb 26, 2024
CodeGat added a commit to ACCESS-NRI/ACCESS-OM2 that referenced this issue Feb 26, 2024
* cd.yml: Moved tagging logic to before deployment

* ci.yml: Added tagging logic to before prerelease deployment

* git user.email now uses github-actions userid
See ACCESS-NRI/reproducibility#19

* Updated to use the organisational vars for GH_ACTIONS_BOT_GIT_USER_{NAME,EMAIL}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant