Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FESTAT python update #31

Open
wants to merge 20 commits into
base: develop
Choose a base branch
from

Conversation

swapanmallicksmhi
Copy link

No description provided.

@ewhelan ewhelan self-requested a review February 13, 2024 09:31
@ewhelan ewhelan self-assigned this Feb 13, 2024
@ewhelan ewhelan added the enhancement New feature or request label Feb 13, 2024
@ewhelan
Copy link
Collaborator

ewhelan commented Feb 13, 2024

Hi @swapanmallicksmhi

I am going to a real pain in the neck for you ...

The script you have submitted seems to be very dependent on Atos@ECMWF. I can work with you to make this more general. I have some bash logic that we can re-use to make this more user-friendly.

@swapanmallicksmhi
Copy link
Author

Hi @ewhelan,

Sure, I will be happy to work with you in this. Please provide the bash logic.

@ewhelan
Copy link
Collaborator

ewhelan commented Feb 13, 2024

I have definitely broken what you have developed but it is now a little more user-friendly. Take a look and let me know what you think.

doc/tools/festat.md Show resolved Hide resolved
scripts/CMakeLists.txt Show resolved Hide resolved
#SBATCH --time=02:00:00
#

EXP=SURF_CARRA2_CY46
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not believe we should have a dependency on a Harmonie experiement to run this.


EXP=SURF_CARRA2_CY46
ENV=${HOME}/hm_home/$EXP
source ${ENV}/Env_system
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should extract what is environment is needed. i.e. the correct modules at ECMWF.

source ${ENV}/Env_system

export MPPEXEC="srun"
export NPROC=999
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard-codings for NPROC should be replaced by command-line settings

&NAMFESTAT
NPRINTLEV=0,
NCASES=$NPROC,
NFRGRP=9,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be derived, I guess, rather than hard-coded.

LUVBAL=.FALSE.,
OUTBAL='stab.bal'
OUTCVT='stab.cvt',
OUTCVU='stab.cv',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be useful to add the NetCDF swithc here (LNETCDF_IO) as an option?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants