Rename feeThresholdSat to maxFeeFlatSat

[thomash-acinq]

The new name should be much easier to understand and matches the name used in eclair-core

[codecov-commenter]

Codecov Report

Merging #2079 (02ea55b) into master (59b4035) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2079   +/-   ##
=======================================
  Coverage   87.57%   87.57%           
=======================================
  Files         166      166           
  Lines       12717    12717           
  Branches      536      536           
=======================================
  Hits        11137    11137           
  Misses       1580     1580           

Impacted Files	Coverage Δ
...scala/fr/acinq/eclair/crypto/WeakEntropyPool.scala	89.47% <0.00%> (-5.27%)	⬇️
...ala/fr/acinq/eclair/balance/ChannelsListener.scala	93.10% <0.00%> (-3.45%)	⬇️
...c/main/scala/fr/acinq/eclair/channel/Channel.scala	87.86% <0.00%> (ø)
...cala/fr/acinq/eclair/payment/relay/NodeRelay.scala	97.56% <0.00%> (+1.62%)	⬆️

[t-bast]

Good idea, this name was really confusing.

We are losing the unit with your proposal though, it's not obvious for most users whether we'll expect satoshis or millisatoshis here. It's not very elegant, but we've chosen for now to include the units in the API parameter names, I think it's a good idea to keep that, so what about one of these:

• maxFeeSat / maxFeePct
• maxFeeSatoshis / maxFeePct
• maxFeeFlatSat / maxFeePct
• maxFeeFlatSatoshis / maxFeePct

[thomash-acinq]

You're right, I just copied the name that we have in the code but there we have types to encode the unit.