Increase CLOSED timeout from 10s to 1min
#2281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives more time to rollback the funding tx in case where we moved from `WAIT_FOR_FUNDING_INTERNAL`->`CLOSED`. We could do it differently, with an additional step, or by only sending the "shutdown" symbol after we receive the wallet response for this specific transition, but it would be more complicated.
pm47
changed the title
CLOSED timeout from 10s to 1min
t-bast
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives more time to rollback the funding tx in case where we moved from
WAIT_FOR_FUNDING_INTERNAL->CLOSEDand unlock utxos.We could do it differently, with an additional state, or by only sending the "shutdown" symbol after we receive the wallet response for this specific transition, but it would be more complicated.