Update Bolt 3 tests #2605
Merged
Update Bolt 3 tests #2605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add latest changes from lightning/bolts#1018
Add latest fixes from lightning/bolts#1056
sstone
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests from Bolt 3 were a bit weird: the amounts didn't really match the funding transaction, but we don't verify it.
Also, the order of HTLCs having the same payment hash were inverted compared to the spec tests.
Overall, this test file is messy and hard to follow, but I think it has value.
See lightning/bolts#1018 and lightning/bolts#1056