Update to bitcoind 24.1 #2711
Merged
Update to bitcoind 24.1 #2711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets us use the new `gettxspendingprevout` instead of fetching the whole mempool when looking for txs spending one of our channels.
A new feature was added to bitcoind 24.1+ that tries to make the change output indistinguishable from the payment output. This is a great for privacy, but it adds randomness to coin selection and uses a non-minimal set of inputs sometimes. We work around this by updating the amount of the output we want bitcoind to use to make sure it's sufficient to pay for both the channel funding and the change output. This shouldn't be too much of an issue for normal operation, where we'll sometimes use two inputs instead of one, which costs more fees, but increases privacy. See bitcoin/bitcoin#24494 for details.
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #2711 +/- ##
==========================================
+ Coverage 85.96% 85.98% +0.01%
==========================================
Files 215 215
Lines 17731 17731
Branches 765 775 +10
==========================================
+ Hits 15243 15246 +3
+ Misses 2488 2485 -3
|
sstone
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us use the new
gettxspendingprevoutinstead of fetching the whole mempool when looking for txs spending one of our channels.I had to change many of the test values in
InteractiveTxBuilderSpecbecausebitcoindupdated the way it generates the change output in bitcoin/bitcoin#24494 which had mostly an impact on outputs around the 50k sat threshold. Bitcoin Core tries to create a change output with an amount similar to the main output for privacy reason (and has done so for a few versions already). While this makes sense for most users, it creates more liquidity churn for LSPs: ideally that's something we'd like to turn off (we probably don't want to pay for privacy). We may want to start using our own fork ofbitcoindwith smallcoinselectiontweaks if we want to preserve our utxo set.