Remove code to automatically create eclair-managed wallet #2746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code made the onchain key manager more complex, and for older wallets (when nodes are moved to a new machine for example) we need to provide a manual process for creating a new empty wallet and importing descriptors generated by Eclair. => It is simpler to always use this manual process.
sstone
force-pushed
the
implement-external-signer-remove-createwallet
branch
from
5e317d7
to
692cdf2
Compare
t-bast
reviewed
Sep 20, 2023
eclair-core/src/test/scala/fr/acinq/eclair/blockchain/bitcoind/BitcoindService.scala
Outdated
Show resolved
Hide resolved
pm47
reviewed
Sep 20, 2023
There was a problem hiding this comment.
The file BitcoinCoreKeys.md isn't great imo. The raw content is there, but it's not well structured and doesn't highlight what commands/actions the operator should run vs the rest (context, examples, warnings, etc.). Plus there are numerous syntax/case/sentence ending inconsistencies.
t-bast
approved these changes
Sep 21, 2023
pm47
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code made the onchain key manager more complex, and for older wallets (when nodes are moved to a new machine for example) we need to provide a manual process for creating a new empty wallet and importing descriptors generated by Eclair.
=> It is simpler to always use this manual process.