Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(iOS+Android) es-419 strings localized/updated #494

Merged
merged 23 commits into from
Jan 2, 2024

Conversation

BitByBitByBitByBit
Copy link
Contributor

This is the localization to es-419 (Spanish for Latin America and the Caribbean).

The English strings have been translated from scratch as the current Spanish translation could be more suitable for Spain.

@dpad85
Copy link
Member

dpad85 commented Dec 21, 2023

Thanks for this large update! We'll review it asap.

@BitByBitByBitByBit BitByBitByBitByBit changed the title (iOS) Strings localized to es-419 (Spanish for Latin America and the Caribbean) (iOS+Android) Strings localized to es-419 (Spanish for Latin America and the Caribbean) Dec 28, 2023
@BitByBitByBitByBit
Copy link
Contributor Author

I have updated strings.xml and important_strings.xml for the Android localization too (I modified the PR title accordingly, let me know if this needs to be done differently).

@BitByBitByBitByBit BitByBitByBitByBit changed the title (iOS+Android) Strings localized to es-419 (Spanish for Latin America and the Caribbean) (iOS+Android) es-419 strings localized/updated Dec 28, 2023
Copy link
Member

@dpad85 dpad85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@dpad85 dpad85 merged commit 29134c7 into ACINQ:master Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants