Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mindmap app floods log files in NC26 due to deprecated /appinfo/app.php #184

Closed
mkrecek234 opened this issue Mar 2, 2023 · 7 comments
Closed

Comments

@mkrecek234
Copy link

mkrecek234 commented Mar 2, 2023

Mindmap needs to refactor to IBoostrap for NC26, currently it throws this error once a second in the NC26 log file:
/appinfo/app.php is deprecated, use \\OCP\\AppFramework\\Bootstrap\\IBootstrap on the application class instead.

{"reqId":"qJAUrVRob5HGFSAkfzgS","level":0,"time":"2023-03-02T10:40:59+00:00","remoteAddr":"","user":"nxadmin","app":"files_mindmap","method":"GET","url":"/ocs/v2.php/apps/user_status/api/v1/statuses/admin","message":"/appinfo/app.php is deprecated, use \\OCP\\AppFramework\\Bootstrap\\IBootstrap on the application class instead.","userAgent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/16.4 Safari/605.1.15","version":"26.0.0.7","data":{"app":"files_mindmap"},"id":"64007d4d7c879"}

@ACTom Can this be fixed easily?

@nursoda
Copy link

nursoda commented May 30, 2023

Does 0.0.28 fix this, too!?

@eurodrew555
Copy link

Doesn't look fixed in 0.0.28, I'm still seeing this error in my debug logs

@mkrecek234
Copy link
Author

Does 0.0.28 fix this, too!?

No it does not fix this. Still one debug entry in NC's log per second triggered by mindmap...

@kds69
Copy link

kds69 commented Jun 8, 2023

+1

@smarinier
Copy link
Contributor

Hi @ACTom, i've got a commit moving from app.php to Application.php, so that this annoying warning is fixed. Woud you mind to accept me as contributor so that i can propose you a pull request ?

Note :One thing is that last version of files_mindmap would require now NC 20 with this fix.

@mkrecek234
Copy link
Author

mkrecek234 commented Aug 20, 2023

@smarinier Could you fork this repo, commit your change and then eventually make a PR to merge from your forked repo in this one? Would be keen also to get the fix fast.

smarinier added a commit to smarinier/files_mindmap that referenced this issue Aug 21, 2023
@smarinier
Copy link
Contributor

@smarinier Could you fork this repo, commit your change and then eventually make a PR to merge from your forked repo in this one? Would be keen also to get the fix fast.

Hi @mkrecek234 and @ACTom, as asked, i've forked and submitted my PR. You can have a look and even test it.
Yours,

@ACTom ACTom closed this as completed in 7116b51 Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants