fix(users): allow saving users with date_of_birth as empty string (#100)

AEGEE · Aug 24, 2020 · 668b68a · 668b68a
1 parent c26896b
commit 668b68a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/models/User.js b/models/User.js
@@ -156,6 +156,8 @@ User.beforeValidate(async (user) => {
     if (typeof user.phone === 'string') user.phone = user.phone.trim();
     if (typeof user.address === 'string') user.address = user.address.trim();
     if (typeof user.about_me === 'string') user.about_me = user.about_me.trim();
+
+    if (typeof user.date_of_birth === 'string' && user.date_of_birth === '') user.date_of_birth = null;
 });
 
 async function encryptPassword(user) {

diff --git a/test/unit/users.test.js b/test/unit/users.test.js
@@ -97,13 +97,18 @@ describe('Users testing', () => {
         }
     });
 
-    test('should allow empty date_of_birth', async () => {
+    test('should allow null date_of_birth', async () => {
         const user = generator.generateUser();
         delete user.date_of_birth;
 
         await User.create(user);
     });
 
+    test('should allow empty string date_of_birth', async () => {
+        const user = generator.generateUser({ date_of_birth: '' });
+        await User.create(user);
+    });
+
     test('should fail with date_of_birth in the future', async () => {
         try {
             const user = generator.generateUser({