fix(user): not allow numerical usernames. Partially fixes MA-176 (#233)

* fix(user): not allow numerical usernames * chore(user): add test
AEGEE · Feb 22, 2021 · c8f6622 · c8f6622
1 parent 76ab1f3
commit c8f6622
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/models/User.js b/models/User.js
@@ -19,6 +19,9 @@ const User = sequelize.define('user', {
                 if (!USERNAME_REGEX.test(value)) {
                     throw new Error('Username should only contain letters, numbers, dots, underscores and dashes.');
                 }
+                if (value.match(/^[0-9._-]+$/)) {
+                    throw new Error('Username should have at least 1 letter.');
+                }
             }
         },
         unique: true

diff --git a/test/api/campaigns-submission.test.js b/test/api/campaigns-submission.test.js
@@ -73,6 +73,24 @@ describe('Campaign submission', () => {
         expect(res.body.errors).toHaveProperty('username');
     });
 
+    test('should fail if the username has no letters', async () => {
+        const campaign = await generator.createCampaign();
+        const user = generator.generateUser({ username: '123' });
+
+        const res = await request({
+            uri: '/signup/' + campaign.url,
+            method: 'POST',
+            headers: { 'X-Auth-Token': 'blablabla' },
+            body: user
+        });
+
+        expect(res.statusCode).toEqual(422);
+        expect(res.body.success).toEqual(false);
+        expect(res.body).not.toHaveProperty('data');
+        expect(res.body).toHaveProperty('errors');
+        expect(res.body.errors).toHaveProperty('username');
+    });
+
     test('should fail if the first name is invalid', async () => {
         const campaign = await generator.createCampaign();
         const user = generator.generateUser({ first_name: '!@#!@#D' });