Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(user): not allow numerical usernames. Partially fixes MA-176 #233

Merged
merged 2 commits into from
Feb 22, 2021

Conversation

WikiRik
Copy link
Member

@WikiRik WikiRik commented Feb 15, 2021

Frontend still need to be fixed and database needs to be cleaned of these people

@WikiRik WikiRik requested a review from a team February 15, 2021 14:05
@codecov
Copy link

codecov bot commented Feb 15, 2021

Codecov Report

Merging #233 (66e8c44) into master (b3fe6a6) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #233   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           42        42           
  Lines         1335      1337    +2     
  Branches       210       211    +1     
=========================================
+ Hits          1335      1337    +2     
Impacted Files Coverage Δ
models/User.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3fe6a6...66e8c44. Read the comment docs.

@WikiRik WikiRik merged commit c8f6622 into master Feb 22, 2021
@WikiRik WikiRik deleted the no-ids-username branch February 22, 2021 15:54
serge1peshcoff pushed a commit that referenced this pull request Feb 22, 2021
## [1.31.7](1.31.6...1.31.7) (2021-02-22)

### Bug Fixes

* **user:** not allow numerical usernames. Partially fixes MA-176 ([#233](#233)) ([c8f6622](c8f6622))
@serge1peshcoff
Copy link
Member

🎉 This PR is included in version 1.31.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants