ci(test): using docker images for test and updating to Slack orb v4 #333
Conversation
.circleci/config.yml
Outdated
| failure_message: The Docker image for \`$CIRCLE_PROJECT_REPONAME\` build and push has failed. | ||
| - slack/notify: | ||
| event: pass | ||
| template: basic_success_1 |
There was a problem hiding this comment.
Something like this;
So basically it will tell us that docker-push-and-build passed for the master branch of discounts
There was a problem hiding this comment.
can it be customized? it'd be nice for us to see which version was built and pushed, like in the setup I did
There was a problem hiding this comment.
We can make custom notifications with the Block Kit Builder from Slack. I'll take a look to see if I can make something similar to what we have now
There was a problem hiding this comment.
Okay, made a custom notification. Not sure how I could get the green bar in front that the old message had, but this should also suffice imo. Name and avatar of the app can be changed in Slack, no code needed for that
There was a problem hiding this comment.
@serge1peshcoff is the message above good enough or do you want a visual indicator as well to see if it was successfull?
Codecov Report
@@ Coverage Diff @@
## master #333 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 16 16
Lines 286 286
Branches 36 36
=========================================
Hits 286 286 Continue to review full report at Codecov.
|
|
I was just talking to @linuxbandit about this PR and that I tried doing parallel tests before (few months back) but then ran into some issues. I tried it again and now it works! So we can test in parallel which should result in quicker finishing of CI checks (especially on core/statutory where tests take quite long) |
|
🎉 This PR is included in version 1.2.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Needed for semantic release, other updates like done in AEGEE/discounts#333 will be added later
Needed for semantic release, other updates like done in AEGEE/discounts#333 will be added later
I've finished the final things that I wanted to do for the CircleCI config and I've updated everything to the latest version.
I've also written a guide on what needs updating and where the latest versions can be found; https://myaegee.atlassian.net/l/c/CH731sTD
V4 of the Slack orb uses a different setup, so a new Slack app was created for this. The old one with webhooks can be removed after this PR is merged on all repos. A preview of the new Slack messages can be found here; https://github.com/CircleCI-Public/slack-orb/wiki