fix(applications): fetch all bodies once for JC export (#1195)

Co-authored-by: WikiRik <WikiRik@users.noreply.github.com>
AEGEE · Apr 10, 2024 · e718bfa · e718bfa
1 parent 293a2a9
commit e718bfa
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/lib/applications.js b/lib/applications.js
@@ -877,10 +877,12 @@ exports.exportDelegatesJc = async (req, res) => {
         mails = await core.getMails(req, userIds);
     }
 
+    const bodies = await core.getBodies(req);
+
     // Returns a CSV string
     const exportString = await Promise.all(applications.map(async (application) => {
         const user = mails.find((m) => application.user_id === m.id);
-        const body = await core.getBody(req, application.body_id);
+        const body = bodies.find((b) => application.body_id === b.id);
         const regex = /[^a-zA-z\-\ ]/; // eslint-disable-line
         application.first_name = application.first_name.replace(regex, '?');
         application.last_name = application.last_name.replace(regex, '?');

diff --git a/test/api/export-delegates-jc.test.js b/test/api/export-delegates-jc.test.js
@@ -57,7 +57,7 @@ describe('Export Delegates JC', () => {
     });
 
     test('should return the application if it is not cancelled, accepted and a delegate', async () => {
-        await generator.createApplication({ user_id: regularUser.id, status: 'accepted', participant_type: 'delegate' }, event);
+        await generator.createApplication({ user_id: regularUser.id, status: 'accepted', participant_type: 'delegate', body_id: 34 }, event);
         const res = await request({
             uri: '/events/' + event.id + '/applications/export/delegates_jc',
             method: 'GET',