Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't install scrypt in node v12. #51

Closed
atom-yang opened this issue Jul 25, 2019 · 0 comments
Closed

Can't install scrypt in node v12. #51

atom-yang opened this issue Jul 25, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@atom-yang
Copy link
Contributor

atom-yang commented Jul 25, 2019 •
edited
Loading

Describe the bug
Can't install scrypt in node v12.

To Reproduce
Steps to reproduce the behavior:
When npm i or yarn, aelf-sdk requires scrypt.js, and scrypt.js takes scrypt as optional dependencies，which ignore error when installing. aelf-sdk take scrypt as an external package, without scrypt, it can't run.
Here is the problem, the preinstall step of scrypt failed in Node v12.

Expected behavior
Install scrypt successfully

Desktop (please complete the following information):

  • OS: macOS Mojave 10.14.5
  • Node v12.7.0
  • Version v12.7.0

Additional context
Resolve this by writing a custom module which contains scrypt for Node, using crypto.scrypt。

similar issue
@atom-yang atom-yang added the bug Something isn't working label Jul 25, 2019
atom-yang pushed a commit that referenced this issue Jul 25, 2019
fix: 🐛 fix install scrypt error in Node v12
effaea1 
replace scrypt by a custom polyfill using crypto.scrypt

✅ Closes: #51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@atom-yang