Changed complex data type in table #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change of data type should make Igor2 compatible with NumPy V2.0, while being backwards compatible down to at least NumPy V1.19.
Type 1 does not seem to have an actual purpose, but exists due to how the type table was historically structured. It appears that the type number read from files is decremented by 1 when the type is complex. Therefore, type 5 maps to twice type 4 (real and imaginary), type 3 maps two twice type 2, and interestingly, type 1 would be mapped to two text types, which suggests that it doesn't exist at all. At least it is not used in the tests and any IGOR Pro files I encountered. Further evidence for this claim can be found in the MATLAB code found here. For completeness, we map it to
numpy.complex128, but it appears one could map it to anything - perhaps completely eliminate the statement entirely to avoid future confusion (we don't need an Igor3).(This ironically makes it all the more painful that this single line of code is the raison d'être of Igor2, as the assigned type in Igor was the cause of compatibility with later NumPy versions.)