This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
AFHTTPSessionManager now copies its securityPolicy
#2887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mohamede1945 have you changed the SecurityPolicy in your manager other than |
|
Yes |
|
@mohamede1945 so when you do copy it reverted back to the |
|
Please, look at the copy method code, it's obvious that the property is not copied. |
|
@mohamede1945 yes i know the method doesn't have that copy with zone because |
|
@mohamede1945 Would you be willing to create a patch? Thanks! 🍻 |
|
@kcharwood Yeah sure, I'll do it over the weekend. |
| return YES; | ||
| } | ||
|
|
||
| - (id)initWithCoder:(NSCoder *)decoder { |
There was a problem hiding this comment.
Can you change this id to instancetype please.
|
👍 from me. |
kcharwood
added a commit
that referenced
this pull request
Oct 21, 2015
AFHTTPSessionManager copying securityPolicy not getting copied
kcharwood
added a commit
that referenced
this pull request
Oct 21, 2015
|
Merged in to the 3_0_0 branch with f573fdb |
kcharwood
changed the title
AFHTTPSessionManager now copies its securityPolicy
sergiou87
pushed a commit
to plexinc/AFNetworking
that referenced
this pull request
Dec 12, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I tried to copy the AFHTTPSessionManager the securityPolicy doesn't get copied with it.