Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Update AFNetworking dependency to 4.0 #144

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

asam139
Copy link

@asam139 asam139 commented Mar 30, 2020

The last AFNetworking release was released this last Sunday, March 29.
We need to update the dependency to use the last version of AFNetworking together this amazing extension.

Main changes:

  • Update dependency
  • Add headers params to "authenticateUsingOAuthWithURLString" method because now AFNetworking allows to modify the headers directly.
  • Update projects settings
  • Add carthage folder to gitignore file

@andr3a88
Copy link

Any update on this PR?

@flienkamp
Copy link

Are there any chances of this getting merged soon? We are using AFOAuth2Manager for a business app and without this change of updating to AFNetworking 4.0 we'll run into problems with releases starting from December 2020. AFNetworking 3.2.1 still uses UIWebView and Apple sends a warning mail every time we upload a new version to App Store Connect:

"App updates that use UIWebView will no longer be accepted as of December 2020. Instead, use WKWebView for improved security and reliability."

Sure we could use your feature branch in Podfile but it may break after the next update of AFNetworking if this get's never merged.

@andr3a88
Copy link

The PR is stucked (and also the repo). @flienkamp You can remove UIWebView+AFNetworking .m and .h to avoid the UIWebView the warning

@asam139
Copy link
Author

asam139 commented Oct 14, 2020

For the moment, you can use the fork where I have the changes:

pod 'AFNetworking', '~> 4.0'
pod 'AFOAuth2Manager', :git => 'https://github.com/appfluence/AFOAuth2Manager.git', :branch => 'feature/update_to_afnetworking_4'

@flienkamp
Copy link

Thanks for your quick help. Sure I can delete the file UIWebView+AFNetworking but it will be restored after every pod update and if I use the fork I am still not sure if the solution breaks after the next update of AFNetworking. So there are workarounds and that's fine. The open question for me is will this be a long term working solution or is there another one coming? And if there is none coming should we use some other pod for our OAuth handling on the long run?

@andr3a88
Copy link

@asam139 is your solution still valid?

@asam139
Copy link
Author

asam139 commented Jan 14, 2021

Of course it is valid, we are using it in our app successfully

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants