make git-crypt add-gpg-user -k default fool-proof #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike most other keys, the default key is encoded using the name `default` in the file system, but inside the key name is empty. If one actually stores the key name `default` inside, the key is rejected by `validate_key_name`. If one does `git-crypt add-gpg-user` without `-k`, the default key is being used leaving the key name empty and things work. If one specifies `-k default` however, it actually stores the invalid key name `default`. The resulting key file is always rejected by `validate_key_name`. This commit changes the behaviour of `-k default` to behave as if no `-k` were given.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike most other keys, the default key is encoded using the name
defaultin the file system, but inside the key name is empty. If one actually stores the key namedefaultinside, the key is rejected byvalidate_key_name.If one does
git-crypt add-gpg-userwithout-k, the default key is being used leaving the key name empty and things work. If one specifies-k defaulthowever, it actually stores the invalid key namedefault. The resulting key file is always rejected byvalidate_key_name.This commit changes the behaviour of
-k defaultto behave as if no-kwere given.It is not entirely clear to me whether this change would have prevented #230.