Skip to content

Commit

Permalink
Tweak .eslintrc due to yarn/eslint issue
Browse files Browse the repository at this point in the history
When using yarn, eslint is loading an older version of eslint-plugin-import, which causes problems in the current configuration.  This commit fixes the problems by disabling the problem rule and adjusting the problem glob.

See: yarnpkg/yarn#3332

And: import-js/eslint-plugin-import#602
  • Loading branch information
cmoesel committed May 9, 2017
1 parent 9ba54c1 commit 969db6a
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
"no-underscore-dangle": ["error", { "allow": ["_id"] }], // because mongo
"no-unused-vars": [ "error", { "args": "none" } ], // don't check function arguments
"no-plusplus": ["error", { "allowForLoopAfterthoughts": true }], // allow ++ in for loop expression
"import/no-extraneous-dependencies": ["error", {"devDependencies": ["src/helpers/*.js"]}] // don't check helpers for extraneous deps
"import/no-named-default": "off", // turning it off since it's currently broken w/ yarn (see: https://github.com/yarnpkg/yarn/issues/3332)
"import/no-extraneous-dependencies": ["error", {"devDependencies": ["**/src/helpers/*.js"]}] // don't check helpers for extraneous deps (note: this glob must be preceeded by '**' due to bug in eslint-plugin-import@2.0.1. See: https://github.com/benmosher/eslint-plugin-import/issues/602)
}
}

0 comments on commit 969db6a

Please sign in to comment.