Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support JetStream MaxText user guide #28

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Support JetStream MaxText user guide #28

merged 1 commit into from
Apr 3, 2024

Conversation

JoeZijunZhou
Copy link
Collaborator

  • Fix model_ckpt_conversion.sh llama2 path
  • Add detail description for max_output_length and max_tokens parameters in benchmark script and jetstream
  • Format the code

@JoeZijunZhou JoeZijunZhou requested a review from vipannalla as a code owner April 3, 2024 22:42
vipannalla
vipannalla approved these changes Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@vipannalla vipannalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoeZijunZhou JoeZijunZhou merged commit 90b2a9d into main Apr 3, 2024
3 checks passed
@JoeZijunZhou JoeZijunZhou deleted the zijun/fix-usr-guide branch April 3, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vipannalla vipannalla vipannalla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoeZijunZhou @vipannalla