Align Tokenizer in JetStream #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
JoeZijunZhou
commented
Apr 13, 2024
JoeZijunZhou
commented
- Return token ids instead of custom decode operation result in JetStream; let client do tokenizer decode operation
- Update benchmark script and requester tool to use JetStream tokenizer seqio library for tokenizer decode operation
- Use correct method to let tokenizer decode the whole output token id list
- Update unit tests for the above change
- Enforce python type check to benchmark script
- Update README unit test section
gangji
approved these changes
Apr 22, 2024
FanhaiLu1
reviewed
Apr 24, 2024
| // List of responses, one per sample. | ||
| repeated string response = 1; | ||
| // List of responses, one per sample. The list size depends on text generation strategy the engine used. | ||
| repeated RepeatedTokenIds response = 1; |
There was a problem hiding this comment.
Please add your deleted field number to the reserved list, it may messes up deserialization. Here is the reference: https://protobuf.dev/programming-guides/dos-donts/#reserve-tag-numbers
There was a problem hiding this comment.
Why not keep both and let the user choose whether she wants ids or string?
| @@ -37,6 +37,10 @@ message DecodeRequest { | |||
| int32 max_tokens = 4; | |||
| } | |||
| message DecodeResponse { | |||
| // List of responses, one per sample. | |||
| repeated string response = 1; | |||
There was a problem hiding this comment.
Can we still keep a str as option? The internal keep both text and token id.
There was a problem hiding this comment.
I guess we don't want to decode it to str (or piece) in jetstream, since it would have some off in the final result.
There was a problem hiding this comment.
Great! Thanks for making the changes!
FanhaiLu1
approved these changes
Apr 24, 2024
jwyang-google
pushed a commit
that referenced
this pull request
May 6, 2024
* Align Tokenizer in JetStream * Update requirements with pytest dep * Remove mix_decode unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.