Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix benchmark script type issue #59

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Fix benchmark script type issue #59

merged 1 commit into from
Apr 25, 2024

Conversation

JoeZijunZhou
Copy link
Collaborator

@JoeZijunZhou JoeZijunZhou requested a review from yeandy April 25, 2024 20:47
@FanhaiLu1
Copy link
Contributor

I was trying to submit a PR to fix this issue. Saw same error from my side.

@FanhaiLu1 FanhaiLu1 self-requested a review April 25, 2024 21:46
@FanhaiLu1 FanhaiLu1 merged commit f290bdc into main Apr 25, 2024
3 checks passed
@FanhaiLu1 FanhaiLu1 deleted the zijun/fix-script-type branch April 25, 2024 21:50
@yeandy
Copy link
Contributor

yeandy commented Apr 26, 2024

Thanks for the fix @JoeZijunZhou !

bhavya01 pushed a commit to bhavya01/JetStream that referenced this pull request May 1, 2024
@JoeZijunZhou @bhavya01
Fix benchmark script type issue (AI-Hypercomputer#59)
6e3ae27
jwyang-google pushed a commit that referenced this pull request May 6, 2024
@JoeZijunZhou @jwyang-google
Fix benchmark script type issue (#59)
ec4380a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FanhaiLu1 FanhaiLu1 FanhaiLu1 approved these changes

@yeandy yeandy Awaiting requested review from yeandy

@vipannalla vipannalla Awaiting requested review from vipannalla vipannalla is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error with mutable list value in dataclass
3 participants
@JoeZijunZhou @FanhaiLu1 @yeandy