Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test coverage cleanup #81

Merged
merged 4 commits into from
May 17, 2024
Merged

Unit test coverage cleanup #81

merged 4 commits into from
May 17, 2024

Conversation

JoeZijunZhou
Copy link
Collaborator

@JoeZijunZhou JoeZijunZhou commented May 11, 2024 •
edited
Loading

  • Increase unit test coverage from 90% to 96%
  • Enable test coverage threshold (>=96%) in CI.
  • Refactor Orchestrator Driver Decode response handling.
  • Remove unused code.

@JoeZijunZhou JoeZijunZhou force-pushed the zijun/test-coverage branch from 52bc667 to 8e08897 Compare May 14, 2024 23:37
@JoeZijunZhou JoeZijunZhou marked this pull request as ready for review May 16, 2024 20:03
@JoeZijunZhou JoeZijunZhou requested a review from vipannalla as a code owner May 16, 2024 20:03
FanhaiLu1
FanhaiLu1 approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@FanhaiLu1 FanhaiLu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for adding more unit test and doing cleanup!

@qihqi qihqi merged commit 87aa565 into main May 17, 2024
3 checks passed
@qihqi qihqi deleted the zijun/test-coverage branch May 17, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FanhaiLu1 FanhaiLu1 FanhaiLu1 approved these changes

@vipannalla vipannalla Awaiting requested review from vipannalla vipannalla is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoeZijunZhou @FanhaiLu1 @qihqi