fixing suppression when margins is true #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #199 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 9 9
Lines 1086 1092 +6
=======================================
+ Hits 1082 1088 +6
Misses 4 4 ☔ View full report in Codecov by Sentry. |
jim-smith
approved these changes
Mar 8, 2024
|
@mahaalbashir shouldn't there be a test case for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix the crosstab. An issue was raised that when suppression is true and margins is true the cells that violate the rules are not being suppressed.
The problem stemmed from the process of recalculating totals. Initially, the function applied a list of boolean conditions for each true cell in the suppression masks to the dataset and then generated the crosstab. However, it missed applying suppression after calculating the crosstab. This was added in this PR.