fixes bug in way SDC info is displayed via prettify_table #202
+197
−3,105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #202 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 9 9
Lines 1092 1093 +1
=======================================
+ Hits 1088 1089 +1
Misses 4 4 ☔ View full report in Codecov by Sentry. |
mahaalbashir
approved these changes
Mar 28, 2024
mahaalbashir
deleted the
200-prettify_tablestringdata-messes-column-parsing-if-first-variable-value-has-spaces
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug arises due to the fact that prettify_table() use spaces to parse header data into column names
Problem then arise when values of a field have spaces in them - so erroneous columns are created.
Fixed by replacing spaces with underscores in column names.
In practice this does not affect the main output - just the display of the SDC 'masks' table to the user
notebooks.test.ipynb has a number of cells that show this fix in action.
Functionality is tested via an addition to the testing of prettify_table() in test_initial.py