Update to be compatible with Pandas 2.2 #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilio/utils.py
Outdated
Comment on lines
119
to
120
| if "ME" or "MS" in data_freq: | ||
| data_freq = data_freq.replace("ME", "M").replace("MS", "M") |
There was a problem hiding this comment.
Do note that this resolves to
(if "ME") or (if "MS" in data_freq)
and if "blabla" resolves to True. Anything but 0, False, None and empty iterators resolve to True.
But the whole if statement here is not needed, you can move it down to be after the if isinstance(data_freq, str):.
BSchilperoort
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
The only comment on the code is the one I added previously.
Otherwise things look good.
Perhaps it can be nice to see if you can fix the tests on your machine with this PR from Peter: phenology/springtime#164 (comment)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the following: