Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement longest common subsequence #63

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

avi-dey
Copy link
Contributor

@avi-dey avi-dey commented Oct 11, 2023

Longest Common Subsequence

Description

Implemetation of longest common subsequence function that returns the length of the longest common subsequence. If there is no common subequence, it would simply return 0.

Related Issue

Closes: #27

Checklist

Before submitting this pull request, please ensure that you have:

  • Followed the code style and conventions.
  • Added appropriate comments and documentation.
  • Updated or added unit tests, if necessary.
  • Checked for any linting errors or warnings.
  • Verified that the code builds and runs without errors.

Author

Avijit Dey (@avi-dey )

@Tinny-Robot
Copy link
Member

@avi-dey your code is failing pylint test try to fix it.
thank you

@Tinny-Robot Tinny-Robot added enhancement New feature or request good first issue Good for newcomers hacktoberfest labels Oct 14, 2023
@avi-dey
Copy link
Contributor Author

avi-dey commented Oct 15, 2023

you have any idea why it's failing? i'm getting 9+ rating in local environment @Tinny-Robot

@matt-wisdom
Copy link
Member

you have any idea why it's failing? i'm getting 9+ rating in local environment @Tinny-Robot

Please, avoid using spaces in file/folder names. Instead of naming a folder "dynamic programming", use "dynamic_programming".

@avi-dey
Copy link
Contributor Author

avi-dey commented Oct 16, 2023

@matt-wisdom okay. thanks for helping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Longest Common Subsequence
3 participants