Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow speeding up RegexSD, add ddsim interface for it #1308

Merged
merged 4 commits into from
Aug 12, 2024
Merged

Allow speeding up RegexSD, add ddsim interface for it #1308

merged 4 commits into from
Aug 12, 2024

Conversation

andresailer
Copy link
Member

BEGINRELEASENOTES

  • Geant4RegexSensitivesConstruction: allow using regex that don't match the full volume path, reduce time by 40% or so
  • DDSim: add interface for Geant4RegexSensitivesConstruction to geometry construction

ENDRELEASENOTES

@andresailer andresailer changed the title Allow speeding up RegexSD, ddsim interface for it Allow speeding up RegexSD, add ddsim interface for it Aug 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024 •
edited
Loading

Test Results

   14 files     14 suites   6h 38m 6s ⏱️
  365 tests   342 ✅ 0 💤 23 ❌
2 510 runs  2 463 ✅ 0 💤 47 ❌

For more details on these failures, see this check.

Results for commit ea515d5.

♻️ This comment has been updated with latest results.

@andresailer andresailer force-pushed the regex_search branch 2 times, most recently from 37d7bac to c9aed07 Compare August 9, 2024 11:56
@andresailer andresailer marked this pull request as ready for review August 9, 2024 11:56
@andresailer andresailer force-pushed the regex_search branch 2 times, most recently from 60a249a to 1a4a031 Compare August 9, 2024 12:08
@andresailer
Copy link
Member Author

dev4 is also broken in master for this test t_AlignDet_AlephTPC_load (Failed), but not in the tests in the LCG builds https://lcgapp-services.cern.ch/cdash3/tests/6434290

@andresailer andresailer mentioned this pull request Aug 9, 2024
Draft
@andresailer
Copy link
Member Author

Key4hep stack is missing root-project/root#15986

@andresailer
Geant4RegexSensitivesConstruction: use regex_search so we do not have…
efcf842 
… to fully match volume paths.

Speeds up by 50 percent the construction in fiber dual readout calorimeter with 580k volumes (108 s down to 68 s on my machine)
@andresailer
DDSim: add interface to created RegexSDs
d2bfc50
@andresailer
Geant4RegexSD: reduce verbosity of printouts
2de492b
@andresailer
example: BoxOfStraws, simplify regex
ea515d5
@andresailer andresailer merged commit 7260f42 into AIDASoft:master Aug 12, 2024
8 of 14 checks passed
@andresailer andresailer deleted the regex_search branch August 12, 2024 08:35
SanghyunKo added a commit to SanghyunKo/DD4hep that referenced this pull request Aug 15, 2024
@SanghyunKo
fix typo from PR AIDASoft#1308
3111f61
@SanghyunKo SanghyunKo mentioned this pull request Aug 15, 2024
Merged
andresailer pushed a commit that referenced this pull request Aug 15, 2024
@SanghyunKo @andresailer
fix typo from PR #1308
e1017e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andresailer