Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow re-using readouts for different detectors #922

Merged
merged 2 commits into from
Jul 7, 2022

Conversation

andresailer
Copy link
Member

BEGINRELEASENOTES

  • LCIOOutput: Fix exception when trying to use a readout for different sub-detectors
  • EDM4hepOutput: Fix memory leak when re-using readouts for different sub-detectors

ENDRELEASENOTES

emplace doesn't overwrite already existing collection, so this would lead to leaking memory
@andresailer andresailer changed the title Allow re-using readouts for differnt detectors Allow re-using readouts for different detectors Jun 24, 2022
@MarkusFrankATcernch MarkusFrankATcernch merged commit c1ac566 into AIDASoft:master Jul 7, 2022
@andresailer andresailer deleted the reuseColls branch August 17, 2022 11:45
wdconinc added a commit to eic/epic that referenced this pull request Sep 19, 2022
wdconinc added a commit to eic/epic that referenced this pull request Sep 20, 2022
wdconinc added a commit to eic/epic that referenced this pull request Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants