Make Object::id() return an ObjectID since unsigned has become useless
#493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add an ostream operator overload for ObjectID
|
Note that this makes comparisons between |
|
Can you open a ticket for that? (currently absent from work) |
This was referenced Oct 2, 2023
wdconinc
added a commit
to eic/EICrecon
that referenced
this pull request
Nov 11, 2023
…, not uint_t This adds forward compatibility with podio v0.17.1 See AIDASoft/podio#493
wdconinc
added a commit
to eic/juggler
that referenced
this pull request
Nov 11, 2023
7 tasks
wdconinc
added a commit
to eic/EICrecon
that referenced
this pull request
Nov 11, 2023
…, not uint_t This adds forward compatibility with podio v0.17.1 See AIDASoft/podio#493
github-merge-queue bot
pushed a commit
to eic/EICrecon
that referenced
this pull request
Nov 11, 2023
…t uint_t, in podio v0.17.1 (#1106) ### Briefly, what does this PR introduce? This adds forward compatibility with podio v0.17.1. See AIDASoft/podio#493 ### What kind of change does this PR introduce? - [x] Bug fix (issue: compilation falures with podio 0.17.1) - [ ] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No. ### Does this PR change default behavior? No. The modified algorithms are not relying on the most significant bits in the previous ObjectID uint_t that encode the collectionID.
github-actions bot
pushed a commit
to eic/EICrecon
that referenced
this pull request
Nov 14, 2023
…, not uint_t This adds forward compatibility with podio v0.17.1 See AIDASoft/podio#493 (cherry picked from commit 8989cf7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
[Mutable]Object::id()return apodio::ObjectIDinstead ofunsigned, since the latter has become useless with Make CollectionIDs a 32bit hash value of the collection name #412. Fixes Generatedidmethod for user facing types has become useless #438operator<<(std::ostream&)forpodio::ObjectIDENDRELEASENOTES